Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent default on pageup/pagedown when completer is active #3500

Merged
merged 1 commit into from Apr 19, 2018

Conversation

Projects
None yet
2 participants
@gnestor
Copy link
Contributor

gnestor commented Apr 5, 2018

Closes #2518

@gnestor gnestor added this to the 5.5 milestone Apr 5, 2018

@takluyver

This comment has been minimized.

Copy link
Member

takluyver commented Apr 19, 2018

Just got round to testing this, and it works :-)

@takluyver takluyver merged commit fc24f31 into jupyter:master Apr 19, 2018

4 checks passed

codecov/patch Coverage not affected when comparing e3ee807...a69ad50
Details
codecov/project 75.01% remains the same compared to e3ee807
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gnestor gnestor deleted the gnestor:issue-2518 branch Apr 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.