Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use place-hold.it instead of plaecehold.it to create image placeholders #6320

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Use place-hold.it instead of plaecehold.it to create image placeholders #6320

merged 1 commit into from
Mar 21, 2022

Conversation

echarles
Copy link
Member

Contributes to #6319

Use place-hold.it instead of plaecehold.it to create image placeholders

This fixes the following command run during the check_release (link_check) CI step.

'pytest --noconftest --check-links --check-links-cache --check-links-cache-expire-after 604800 --disable-warnings --quiet --check-links-cache-name /home/runner/.cache/releaser-link-check/check-release-links -p no:doctest -c _IGNORE_CONFIG --ignore-glob "docs/source/examples/Notebook/Working With Markdown Cells.ipynb" --ignore-glob "docs-translations/**/README.md" --ignore-glob "docs/source/contributing.rst" --ignore-glob "docs/source/examples/Notebook/JavaScript Notebook Extensions.ipynb" --ignore-glob "CHANGELOG.md" --ignore-glob "notebook/static/components/**/*.*" --check-links-ignore "https://github.com/.*/(pull|issues)/.*"

@echarles echarles mentioned this pull request Mar 21, 2022
Open
3 tasks
@echarles
Copy link
Member Author

This indeed fixes the Check Release / check_release (check_release) step.

I am reluctant to self-merge, @kevin-bates or @jtpio may give a review and merge.

@echarles echarles added this to the 6.4 milestone Mar 21, 2022
blink1073
blink1073 approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 3c54a9a into jupyter:6.4.x Mar 21, 2022
@echarles
Copy link
Member Author

Thx @blink1073

@afshin afshin mentioned this pull request Apr 6, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
maintenance status:resolved-locked
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
2 participants
@echarles @blink1073