Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a label to the upload button #6374

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Add a label to the upload button #6374

merged 2 commits into from
Apr 26, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 26, 2022 •
edited
Loading

To give the same visual cue as in Notebook v6.

Steps towards https://github.com/jupyterlab/retrolab/issues/260

Using the upstream fix from jupyterlab/jupyterlab#12333

Notebook v6

image

Notebook v7

image

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/file-browser-upload-label

@jtpio jtpio added this to the 7.0 milestone Apr 26, 2022
@jtpio jtpio marked this pull request as ready for review April 26, 2022 08:04
@jtpio jtpio changed the title Add label to the upload button Add a label to the upload button Apr 26, 2022
@jtpio jtpio merged commit a17233c into jupyter:main Apr 26, 2022
@jtpio jtpio deleted the file-browser-upload-label branch April 26, 2022 08:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jtpio