Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyside2 support #326

Closed
wants to merge 1 commit into from
Closed

pyside2 support #326

wants to merge 1 commit into from

Conversation

looooo
Copy link

@looooo looooo commented Feb 9, 2019

#279

maybe someone can test if this works with pyqt5.
Also this doesn't fully fix the issues I have with pyside2. There is still this problem:

  File "/home/k/conda/envs/freecad-gcc7/lib/python3.7/site-packages/freecad/ipython/init_gui.py", line 35, in <module>
    console = put_ipy(dock_widget, mw)
  File "/home/k/conda/envs/freecad-gcc7/lib/python3.7/site-packages/freecad/ipython/init_gui.py", line 22, in put_ipy
    widget = RichJupyterWidget(parent=parent)
  File "/home/k/conda/envs/freecad-gcc7/lib/python3.7/site-packages/qtconsole/rich_jupyter_widget.py", line 53, in __init__
    super(RichJupyterWidget, self).__init__(*args, **kw)
  File "/home/k/conda/envs/freecad-gcc7/lib/python3.7/site-packages/qtconsole/jupyter_widget.py", line 118, in __init__
    super(JupyterWidget, self).__init__(*args, **kw)
  File "/home/k/conda/envs/freecad-gcc7/lib/python3.7/site-packages/qtconsole/frontend_widget.py", line 182, in __init__
    self._call_tip_widget = CallTipWidget(self._control)
  File "/home/k/conda/envs/freecad-gcc7/lib/python3.7/site-packages/qtconsole/call_tip_widget.py", line 36, in __init__
    QtGui.QStyle.PM_ToolTipLabelFrameWidth, None, self))
RuntimeError: Internal C++ object (PySide2.QtWidgets.QStyle) already deleted.

@ccordoba12
Copy link
Collaborator

maybe someone can test if this works with pyqt5.

I don't understand why you can't test it yourself. Please be sure that this doesn't break pyqt5 if you want this merged.

@looooo
Copy link
Author

looooo commented Feb 9, 2019

Starting qt-console makes no problems and I guess pyqt5 is used by default.

@looooo
Copy link
Author

looooo commented Feb 9, 2019

also starting qtconsole with pyside2 doesn't make any problems (Also without this diff). The problem occurs if I try to embed qtconsole into FreeCAD. So maybe this is more related to freecad. I close this for now.

@looooo looooo closed this Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants