PR: Fix scrolling issues

[impact27]

Fixes #351
Before:

After:

[impact27]

I still need some tests. I want to check the position of w._control.verticalScrollBar().value().

• Running a single command with enough prompts that it could scroll down to check it stays in place

import time
for i in range(10000):
    print(i)
    time.sleep(.1)

• run this loop and check:
  • The verticalScrollBar scrolls with the output
  • If I move up, the verticalScrollBar stops following the output
  • if I move back down, the verticalScrollBar follows the output again

I am unsure how to do that, are there tests where a console is actually opened?

[ccordoba12]

I am unsure how to do that, are there tests where a console is actually opened?

Not here, but you can find how to do that in this file:

https://github.com/spyder-ide/spyder-kernels/blob/9d62e2e891fb133b086ba42d6f8a3e0c21277b45/spyder_kernels/ipdb/tests/test_matplotlib.py

[impact27]

I added test but I don't know exactly how to run pytest while the rest is in unittest. Could somebody fix the tests? They all run individually on my machine.

[ccordoba12]

@impact27, great job at creating a test for this! I left you some comments to simplify it by using the qtbot fixture, which is part of the pytest-qt package.

Please add it to this line

https://github.com/jupyter/qtconsole/blob/master/.travis.yml#L8

to be able to use it in our tests.

[ccordoba12]

I added test but I don't know exactly how to run pytest while the rest is in unittest

I don't understand what you mean by this. Pytest runs all our tests, as can be seen here:

https://github.com/jupyter/qtconsole/blob/master/.travis.yml#L21

[impact27]

I had to run the new tests first for some reason, by renaming the test file, but at least it works. I would be grateful if someone can explain why I need to do that.

[ccordoba12]

I would be grateful if someone can explain why I need to do that.

No idea. Perhaps moving everything to use pytest-qt would fix that problem.

However, if you want to run your new tests first, please use pytest-ordering and mark them with the @pytest.mark.first decorator. That will make them run at the beginning of our test suite.

[ccordoba12]

I think this is almost ready. One last comment: is it still necessary to rename test_console_widget? I thought that by using pytest-ordering that wouldn't be necessary.

[impact27]

I didn't manage to make it work, I think it is only reordering tests in a same file.

[ccordoba12]

Then there's no need to use pytest-ordering, right?

I also think it's better to rename test_console_widget.py to 00_test_console_widget.py, to avoid future files to cause failures.

[impact27]

test_00_console_widget.py so pytest still runs it.

[ccordoba12]

Yep, right.

[ccordoba12]

Thanks a lot @impact27!