Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent completion strip if it refers to a file #394

Merged
merged 5 commits into from
Nov 17, 2019
Merged

Prevent completion strip if it refers to a file #394

merged 5 commits into from
Nov 17, 2019

Conversation

dalthviz
Copy link
Collaborator

@dalthviz dalthviz commented Nov 16, 2019 •
edited
Loading

A preview:

qc

Fixes spyder-ide/spyder#10692

Pinging @ccordoba12 just in case

@ccordoba12 ccordoba12 added this to the 4.6 milestone Nov 16, 2019
@ccordoba12
Copy link
Collaborator

Thanks a lot @dalthviz for this one! There are two things here:

  1. Tests are failing now.
  2. Could we increase the widget width to see a bit more content or add an horizontal scrollbar to it? In you screenshot above the file extension of Sin título<n>.py is not visible at some point.

@dalthviz
Copy link
Collaborator Author

A new preview:

qc

@dalthviz dalthviz closed this Nov 17, 2019
@dalthviz dalthviz reopened this Nov 17, 2019
@ccordoba12 ccordoba12 changed the title PR: Prevent completion strip if it refers to a file Prevent completion strip if it refers to a file Nov 17, 2019
ccordoba12
ccordoba12 approved these changes Nov 17, 2019
View reviewed changes
Copy link
Collaborator

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @dalthviz! This looks pretty good now!

@ccordoba12 ccordoba12 merged commit c65b692 into jupyter:master Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6
Development

Successfully merging this pull request may close these issues.

Autocomplete in the console only displays file extensions
2 participants
@dalthviz @ccordoba12