Make Qtconsole work on Python 3.8 and Windows #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@minrk, shouldn't this be solved in ipykernel? Or is it necessary to patch every Jupyter application like this? |
|
@minrk, do you have any view on this? |
|
What is the way forward to get the qtconsole fixed on windows/python 3.8? |
|
@ericpre, please merge with master to get the fix to our tests. We'll include your work in our next release (sorry for the delay). |
|
Done. |
|
Thanks! @dalthviz will be in charge of reviewing and testing this on Windows. |
ccordoba12
changed the title
|
Hi @ericpre @ccordoba12 with this fix QtConsole works for me on Windows with Python 3.8 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #405, the qtconsole is currently not working on windows. As a workaround, this PR sets the default asyncio policy on windows with python 3.8 when the app object is created.
For more details, see ipython/ipykernel#480 and tornadoweb/tornado#2608.
Fixes #405.