Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a TypeError in CallTipWidget #419

Merged
merged 2 commits into from
May 7, 2020

Conversation

rayosborn
Copy link
Contributor

@rayosborn rayosborn commented Apr 28, 2020

This is a fix for #383. It applies the same modification to the CallTipWidget hideEvent function as that used to fix CompletionWidget in #367.

Fixes #383.

@ccordoba12 ccordoba12 added this to the 4.8.0 milestone Apr 28, 2020
@wmvanvliet
Copy link
Contributor

Yeah, this would work. However, it would be even better if we could prevent the error from occuring in the first place, rather than just swallowing it and pretend it didn't happen.

@rayosborn
Copy link
Contributor Author

I have no problem with using another solution as long as the fix gets into the next release.

@ccordoba12 ccordoba12 changed the title Fixes a TypeError in CallTipWidget Fix a TypeError in CallTipWidget May 6, 2020
@ccordoba12
Copy link
Collaborator

@rayosborn, please merge with master to get the fix to our tests.

@rayosborn
Copy link
Contributor Author

I'm not sure I understand the request. Should I merge with my fork's master and then reissue the PR?

@ccordoba12
Copy link
Collaborator

No, please run these commands instead:

git remote add upstream https://github.com/jupyter/qtconsole.git
git checkout master
git fetch upstream
git merge upstream/master
git checkout fix-calltipwidget
git merge master
git push origin fix-calltipwidget

Copy link
Collaborator

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rayosborn for your help!

@ccordoba12 ccordoba12 merged commit eaea1de into jupyter:master May 7, 2020
@rayosborn rayosborn deleted the fix-calltipwidget branch May 5, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when clicking a calltip away
3 participants