Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point binder to the branch #217

Merged
merged 2 commits into from
Nov 10, 2020
Merged

Point binder to the branch #217

merged 2 commits into from
Nov 10, 2020

Conversation

fcollonval
Copy link
Contributor

@fcollonval fcollonval commented Nov 10, 2020

I think it will make more sense to spin binder on the PR branch than on a PR commit.

@welcome
Copy link

welcome bot commented Nov 10, 2020

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@fcollonval fcollonval marked this pull request as ready for review November 10, 2020 08:34
@consideRatio
Copy link
Member

I think this makes perfect sense, given that this comment workflow is triggered on pull_request_target such as "Opened" rather every time there is a new commit. It would also make sense to make it only trigger on "Opened" rather than all of "opened", "assigned", "reopened", etc.

Thank you @fcollonval for contributing this improvement!

@betatim betatim merged commit 1b99db4 into jupyterhub:master Nov 10, 2020
@welcome
Copy link

welcome bot commented Nov 10, 2020

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants