Update DOCKER_REGISTRY_URL to the recommended one #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @MridulS. Once merged, can we remove the override from mybinder.org-deploy? |
|
Yeah we could revert jupyterhub/mybinder.org-deploy#1937, let me know if I should do it :) |
|
@MridulS that would be great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recommended hostname ( docker/hub-feedback#2113 (comment) ) for docker registry is
https://registry-1.docker.io.This was fixed on mybinder deployment jupyterhub/mybinder.org-deploy#1937, updating the URL here so people depending on dockerhub in their own binderhub deployments don't hit this issue.