Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: bump xterm and xterm-addon-fit #1655

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Apr 9, 2023

This PR bumps the package.json's dependencies and devDependencies. Since we don't have a package-lock.json, the ^ means that in practice we are using the latest major version before and after this change for all packages except for those listed below. I've manually read through these changelogs and searched our code base for something breaking without finding anything.

dependencies:

devDependencies:


@consideRatio consideRatio added maintenance Under the hood improvements and fixes code:html/js/css html/js/css changes. labels Apr 9, 2023
@manics
Copy link
Member

manics commented Apr 10, 2023

Have you already manually verified the UI works (https://binderhub.readthedocs.io/en/latest/contribute.html#develop-user-interface) or does this still need to be checked?

@consideRatio
Copy link
Member Author

No, I'll check!

@consideRatio
Copy link
Member Author

Thanks @manics for helping me test this easily!

I've verified things look as usual:

  • in the main view with the form allowing users to input what repo to build/launch
  • in the "clicked a link to launch directly" view

The failure seen is because I've not started a jupyterhub to launch etc, but the terminal looks fine and like before.

image

@consideRatio consideRatio merged commit f45dc0b into jupyterhub:main Apr 11, 2023
@consideRatio
Copy link
Member Author

Thanks for the review @manics and @sgibson91!!

consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Apr 11, 2023
jupyterhub/binderhub#1655 Merge pull request #1655 from consideRatio/pr/update-package-json
@consideRatio consideRatio self-assigned this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code:html/js/css html/js/css changes. maintenance Under the hood improvements and fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants