Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jquery dependency #272

Merged
merged 5 commits into from
Jun 21, 2022
Merged

Remove jquery dependency #272

merged 5 commits into from
Jun 21, 2022

Conversation

yuvipanda
Copy link
Contributor

Ref #199

@yuvipanda
Copy link
Contributor Author

This should speed up page loads a little bit. New size of bundle is 372KB.

@yuvipanda yuvipanda mentioned this pull request Jun 14, 2022
Merged
GeorgianaElena
GeorgianaElena approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks @yuvipanda!

@GeorgianaElena GeorgianaElena mentioned this pull request Jun 14, 2022
Closed
@yuvipanda yuvipanda merged commit 8f017c3 into jupyterhub:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgianaElena GeorgianaElena GeorgianaElena approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuvipanda @GeorgianaElena @consideRatio