Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Oauth2 authenticator #59

Closed
dmvieira opened this issue Dec 6, 2016 · 3 comments
Closed

Generic Oauth2 authenticator #59

dmvieira opened this issue Dec 6, 2016 · 3 comments

Comments

@dmvieira
Copy link
Contributor

dmvieira commented Dec 6, 2016

Hey guys, why we don't have a default implementation for oauth2?

@minrk
Copy link
Member

minrk commented Dec 7, 2016

There is a base class that implements the common parts (oauth2.OAuthenticator). There's a last step needed for turning the access token on the callback into a username, which seems different for each provider. That's the only difference between them right now. I'm not aware of a generic implementation of this. Is there a generic way to ask an oauth provider the username corresponding to an access token?

@dmvieira
Copy link
Contributor Author

dmvieira commented Dec 7, 2016

Yes, there is an RFC https://tools.ietf.org/html/rfc6749#section-4.4

I'm doing here ;)

@minrk
Copy link
Member

minrk commented Feb 16, 2017

closed by #60

@minrk minrk closed this as completed Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants