Adding oauth2 generic RFC authentication #60
Conversation
|
|
||
| class OAuth2EnvMixin(OAuth2Mixin): | ||
| _OAUTH_ACCESS_TOKEN_URL = os.environ.get('OAUTH2_TOKEN_URL', '') | ||
| _OAUTH_AUTHORIZE_URL = os.environ.get('OAUTH2_AUTHORIZE_URL', '') |
There was a problem hiding this comment.
How could I get these attributes using trailets?
I really don't know a better solution than env vars
There was a problem hiding this comment.
Env vars are the only thing really available at this level, so this is fine.
dmvieira
changed the title
| @@ -1,104 +1,135 @@ | |||
| """ | |||
| Base classes for Custom Authenticator to use GitHub OAuth with JupyterHub | |||
There was a problem hiding this comment.
To avoid confusion / compatibility, can you put the new class in oauthenticator/generic.py, rather than changing what oauthenticator.oauth2 provides and means?
| ) | ||
|
|
||
| token_url = Unicode( | ||
| os.environ.get('OAUTH2_USERDATA_METHOD', 'GET'), |
| pass | ||
|
|
||
|
|
||
| class OAuth2OAuthenticator(OAuthenticator): |
There was a problem hiding this comment.
Can you use Generic as the name, too? GenericOAuthenticator, etc.?
| @@ -1,6 +1,7 @@ | |||
| # include github, bitbucket, google here for backward-compatibility | |||
| # don't add new oauthenticators here. | |||
| from .oauth2 import * | |||
| from .generic import * | |||
There was a problem hiding this comment.
See the comment above for 'don't add new things here'. Authenticators should be imported directly from their submodule, so that we don't import all the unused Authenticators as this package grows.
|
|
||
| login_service = "OAuth2" | ||
|
|
||
| client_id_env = 'OAUTH2_CLIENT_ID' |
There was a problem hiding this comment.
I think this can leave the defaults from the parent class, of OAUTH_...
|
I think it's now ready ;) Really thx |
|
I'm using here and it's working ;) |
|
Thanks! |
Following https://tools.ietf.org/html/rfc6749