Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom stylesheet and bump sphinx version #465

Merged
merged 3 commits into from
Oct 13, 2021
Merged

Remove custom stylesheet and bump sphinx version #465

merged 3 commits into from
Oct 13, 2021

Conversation

diego-plan9
Copy link
Contributor

Closes #460

  • Remove the usage of app.add_stylesheet, as it looks like it is really not used as discussed in the issue.
  • Bump the sphinx version as suggested in the issue as well. The maximum version pinning can be removed with New pip release request autodoc-traits#5 - under sphinx >4, an error related to PyClassmember causes the build to fail.

@consideRatio consideRatio merged commit bff5ce7 into jupyterhub:master Oct 13, 2021
@diego-plan9 diego-plan9 deleted the doc/stylesheet-usage branch October 13, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio left review comments

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using app.add_css_stylesheet() in conf.py
2 participants
@diego-plan9 @consideRatio