[GitHub] fix implementation of populate_teams_in_auth_state #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using tornado's HTTPClient, there will be an error thrown by default as documented in https://www.tornadoweb.org/en/stable/httpclient.html#tornado.httpclient.HTTPClient.
consideRatio
changed the title
5 tasks
|
Thanks, @consideRatio! |
yuvipanda
added a commit
to yuvipanda/pilot-hubs
that referenced
this pull request
May 17, 2022
Brings in jupyterhub/oauthenticator#504 Ref 2i2c-org#1313 This reverts commit 3117d23.
yuvipanda
added a commit
to yuvipanda/pilot-hubs
that referenced
this pull request
May 17, 2022
Brings in jupyterhub/oauthenticator#504 Ref 2i2c-org#1313 This reverts commit 3117d23.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using tornado's HTTPClient, there will be an error thrown by default as documented in tornado.httpclient.HTTPClient.
Fixes broken implementation of
GitHubOAuthenticator.populate_teams_in_auth_statein #498 as caused by my code suggestion addingresp.raise_for_status().