Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intern Guide: Preparing the final application #142

Merged
merged 8 commits into from
Jan 13, 2023

Conversation

sgibson91
Copy link
Member

@sgibson91 sgibson91 commented Nov 24, 2022

Add guide for preparing final application

Covers ideas discussed in our retrospective, specifically around community questions and using the timeline section of the application to our advantage

relates to #45

Link to rendered docs

Comment on lines +61 to +63
1. **In your own words, what problem is the project attempting to solve?**
(_50 words max_)
2. **In your own words, what is the main goal of the project?** (_50 words max_)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these the best questions we could ask? What could we ask instead?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the questions. Can you also consider one related to what success looks like for the intern within the specific project? I believe such a question would help in evaluating the applicant's understanding of the project's problem and deliverable(s).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that a question that gets at trying to describe concretely what the end of a successful internship would be helpful.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a new question to this section, what do you both think?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added question looks great :)

@sgibson91
Copy link
Member Author

sgibson91 commented Nov 24, 2022

@yochannah @jilaga if you have thoughts as well, I would love to hear them! 🙏🏻

@sgibson91
Copy link
Member Author

@alwasega @Sheila-nk @bl-aire I wondered if you three could review this documentation and let us know if having this information would've been useful during your application? Thank you!

@alwasega
Copy link

@alwasega @Sheila-nk @bl-aire I wondered if you three could review this documentation and let us know if having this information would've been useful during your application? Thank you!

The information would have been very useful. I, especially, remember having trouble with my project outline and having the samples as included here would have really helped.

I noted some unclear parts in the documentation though:

Start developing your final application only once you have experience iterating on your pull requests to get them ready to merge.

As an applicant, I will be wondering what this really means. Can it also be made clear that PRs do not have to be merged before one can work on their final application.

We highly recommend sharing a rough draft of your application at least one week before the deadline.

Please include the channels through which one can share the drafts.

@Sheila-nk
Copy link

@alwasega @Sheila-nk @bl-aire I wondered if you three could review this documentation and let us know if having this information would've been useful during your application? Thank you!

👏 This is really great and useful work. It is quite comprehensive and will be handy during the final application process. I like that you added examples of successful applications. I also like that the applicants are encouraged to share their final applications with the community for feedback.

Apart from the part that @alwasega mentioned about "experience iterating on your pull requests", no notes from me. ❤️

Copy link
Member

@minrk minrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a great resource, thanks @sgibson91!

docs/source/interns/prepare-application.md Show resolved Hide resolved
Comment on lines +61 to +63
1. **In your own words, what problem is the project attempting to solve?**
(_50 words max_)
2. **In your own words, what is the main goal of the project?** (_50 words max_)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that a question that gets at trying to describe concretely what the end of a successful internship would be helpful.

@sgibson91
Copy link
Member Author

We highly recommend sharing a rough draft of your application at least one week before the deadline.

Please include the channels through which one can share the drafts.

@alwasega We are working on getting the channels set up in this issue, but it hasn't had a lot of traction yet 😕 jupyterhub/team-compass#584

@bl-aire
Copy link

bl-aire commented Jan 12, 2023

@alwasega @Sheila-nk @bl-aire I wondered if you three could review this documentation and let us know if having this information would've been useful during your application? Thank you!

This would have been really helpful.
I am sure it will help future applicants because it will make the application process feel less overwhelming. Steps to take and even samples of successful applications are provided which they can use as templates to tell their unique stories.

@alwasega
Copy link

@alwasega We are working on getting the channels set up in this issue, but it hasn't had a lot of traction yet 😕 jupyterhub/team-compass#584

Okay :) . I would like to be a part of the group that assists with answering questions during the contribution phase. Will check the issue in more detail and give my thoughts.

- Describe what it means to iterate on a pull request
- Note that it is ok if pull requests are not merged
As the applicant to describe what a successful completion of the
internship would looks like for them
Comment on lines 20 to 41
Your first priority during the contribution period should be figuring out how
to become an effective contributor. Start developing your final application only
once you have experience iterating on your pull requests to get them ready to
merge. This way, you'll have a much better idea of how much you can accomplish
and how you may wish to tackle your chosen project. **It is ok if your pull
requests have not been merged when you begin working on your final application,
or if they are not merged before the application deadline.**

```{note} What does iterating on your pull request mean?
When pull requests are opened on a project, other members of the community
will review the changes and provide feedback. Sometimes it is important that
this feedback be incorporated into the pull request before it can be merged.
And sometimes you may be asked to make further changes once the first set of
feedback has been addressed. This is what we mean by "iterating on your pull
requests" - it's referring to this feedback cycle.

This feedback cycle is normal behaviour is most open source communities and,
generally speaking, maintainers try to keep the cycle short. You may be asked
to open new issues or new pull requests to track pieces of feedback that the
team would like to include in the future, but don't think it is necessary to
include in your current pull request.
```
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alwasega Does this new section clarify your question around what it means to iterate on a PR?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does. I also like that you have added that the PRs do not have to be merged for one to work on their final applications.

@sgibson91 sgibson91 merged commit 8d7b47e into jupyterhub:main Jan 13, 2023
@sgibson91 sgibson91 deleted the intern-guide/final-application branch January 13, 2023 16:08
@sgibson91
Copy link
Member Author

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants