Add travis support for traefik testing #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
reviewed
Oct 1, 2018
traefik/test_traefikPrefixRouting.py
Outdated
| stdout=PIPE) | ||
| defaultBackend = Popen(["python", "dummyHttpServer.py",str(defaultBackendPort)], | ||
| defaultBackend = Popen(["python", dummyServerPath, str(defaultBackendPort)], |
There was a problem hiding this comment.
A useful trick here: use sys.executable as the first arg, then it is not sensitive to when the PATH might point to a different Python.
There was a problem hiding this comment.
You're totally right, I've just updated the pull request. Thanks a lot for the feedback!
|
The test looks and works great! I left a comment about how to resolve the Python executable. |
|
Awesome, thanks! |
This was referenced Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @minrk ! I added travis support to test traefik's prefix-based routing. I activated travis on my fork and the tests pass, yay! Let me know if everything works for you too. You should be able now to link travis to the outreachy upstream repo and add the build badge.