Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github workspace as safe directory on commit local Dockerfile for Binder cache #90

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

jerrybonnell
Copy link
Contributor

Address Git security issue that causes Docker builds to suddenly fail.

See #89 (comment) and actions/checkout#760

@welcome
Copy link

welcome bot commented Apr 26, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@yuvipanda
Copy link
Collaborator

Thank you, @jerrybonnell! Were you able to test this somewhere?

@jerrybonnell
Copy link
Contributor Author

@yuvipanda We are using repo2docker action in this project. Here is our workflow and the passing build.

@yuvipanda
Copy link
Collaborator

@jerrybonnell that is a super cool project! Thank you for contributing this fix <3

@yuvipanda yuvipanda merged commit 228fc18 into jupyterhub:master Apr 26, 2022
@welcome
Copy link

welcome bot commented Apr 26, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants