Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] add tests for R conda #1108

Merged
merged 2 commits into from
Jan 11, 2022
Merged

[MRG] add tests for R conda #1108

merged 2 commits into from
Jan 11, 2022

Conversation

aplamada
Copy link
Contributor

@aplamada aplamada commented Jan 7, 2022

It simply adds tests for R 3.6, 4.0 and 4.1 using conda.

This is a follow up of the closed PR #1086 .
The structure for the tests is as in #1104 .

@yuvipanda Can you please have a look at this new PR?

@yuvipanda
Copy link
Collaborator

@aplamada thanks for making these! Any idea why they are failing?

@aplamada
Copy link
Contributor Author

aplamada commented Jan 8, 2022

@yuvipanda Thanks!
It is not possible to satisfy all dependencies (see below).

Looking for: ['r-base=4.1', 'r-irkernel=1.1', 'r-devtools']
  
Encountered problems while solving.
Problem: package r-irkernel-1.1-r35h6115d3f_0 requires r-base >=3.5,<3.6.0a0, but none of the providers can be installed

Previously it used to downgrade the R version (see here).

@manics manics closed this Jan 8, 2022
@manics manics reopened this Jan 8, 2022
@yuvipanda
Copy link
Collaborator

ahhh. I don't really know enough about conda to know how to fix it tho :|

@manics
Copy link
Member

manics commented Jan 8, 2022

@yuvipanda Do we need to pin the version of r-irkernel? Can we rely on the conda solver to automatically install a compatible version of r-irkernel for whatever r-base version is requested?

mamba install -p {0} r-base{1} r-irkernel=1.2 r-devtools -y && \

@aplamada
Copy link
Contributor Author

aplamada commented Jan 8, 2022

@manics @yuvipanda the new version r-irkernel=1.2 works fine with all conda R tests.

@manics
Copy link
Member

manics commented Jan 11, 2022

Thanks!

@manics manics merged commit a37a205 into jupyterhub:main Jan 11, 2022
@welcome
Copy link

welcome bot commented Jan 11, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants