-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Test R minor version and add more tests #1086
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
@yuvipanda When I noticed the problem with the R version (see #1077 ) I had in mind at least to systematically improve the tests for the minor version, and I thought to do it similar to the Python part. |
I didn't see this PR properly before (sorry @aplamada) and I think I've added very similar tests to #1104. Can you see if any of these tests would be helpful there? If not, let's close this PR? I'm really sorry this wasn't reviewed sooner. I think added tests are always useful, wether they solve the underlying problem or not! |
@yuvipanda Thanks for the reply. I think it makes sense to close this PR. |
@aplamada yeah, that would be great! I haven't really paid any attention to the conda/r stuff at all. Would you be interested in working on that? I can help with more prompt review this time. |
Yes. I am thinking to close this PR and make a new one for conda tests only. |
@aplamada that sounds great. |
Update the R tests and add more tests to address the issues noticed in #1077 .
Feedback is welcome.