Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade base image from to Ubuntu 22.04 from 18.04 #1287

Merged
merged 2 commits into from Sep 18, 2023

Conversation

yuvipanda
Copy link
Collaborator

@yuvipanda yuvipanda commented Jun 13, 2023

18.04 was EOL May 2023, with only paid support now available (https://ubuntu.com/blog/18-04-end-of-standard-support).

Let's bump the default base image to 22.04. This might break some repos that have apt.txt based packages, but I don't really think there's a way around that. If specific package pinning is needed, users unfortunately need to use a Dockerfile.

Closes #1258

18.04 was EOL May 2023, with only paid support now available
(https://ubuntu.com/blog/18-04-end-of-standard-support).

Let's bump the default base image to 22.04. This might break
some repos that have apt.txt based packages, but I don't
really think there's a way around that. If specific package pinning
is needed, users unfortunately need to use a Dockerfile.

Ref jupyterhub#1258
@yuvipanda yuvipanda requested review from minrk and manics June 13, 2023 07:33
@consideRatio consideRatio added maintenance Under the hood fixes and improvements breaking labels Jun 13, 2023
Copy link
Member

@minrk minrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we need to do this, and after EOL seems like the absolute latest we can do it.

Until we have an opt-in path to selecting newer base images, we just have to make this breaking change.

@manics
Copy link
Member

manics commented Jun 13, 2023

How about we make an announcement https://discourse.jupyter.org/tag/announcement before merging/deploying this to mybinder.org, to manage expectations?

@yuvipanda
Copy link
Collaborator Author

Can someone else take on making the announcement? :D

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it would be good to get a notice in the changelog as well under the unreleased section about this breaking change.

I've added a label about it breaking for now

@consideRatio
Copy link
Member

How about we make an announcement https://discourse.jupyter.org/tag/announcement before merging/deploying this to mybinder.org, to manage expectations?

I wonder if we can and should announce this via mybinder.org directly instead of discourse if its to be announced, for example in a banner during loading? If something errors by failing to get installed, this is where they will be.

@rgaiacs
Copy link

rgaiacs commented Jun 13, 2023

I wonder if we can and should announce this via mybinder.org directly

It is a great idea.

@manics
Copy link
Member

manics commented Jun 13, 2023

I wonder if we can and should announce this via mybinder.org directly instead of discourse if its to be announced

How about both? We're using Discourse as the support forum and questions about binder are often handled by non-jupyterhub community members, so I think it's polite to give everyone advance warning.

@minrk
Copy link
Member

minrk commented Jun 13, 2023

Both sound great. I can post to discourse.

@consideRatio
Copy link
Member

consideRatio commented Jun 13, 2023

I opened jupyterhub/mybinder.org-deploy#2663 about not using dev releases in mybinder.org, allowing us to link out to a repo2docker's changelog etc in announcements independently if they are on made on mybinder.org or discouse, where we anyhow would need to describe breaking changes.

Please signal agreement / disagreement or similar, if there is a clear agreement the fix is simple - we just adjust automation in mybinder.org-deploy to not bump to dev releases.

Practically, the action plan I suggest is:

  1. We go for the suggestion in Stop using repo2docker's dev releases, use only stable (or non-dev pre-releases) mybinder.org-deploy#2663
  2. We merge this PR, with a "unreleased" changelog entry made
  3. We make a release of repo2docker
  4. We observe in mybinder.org-deploy that "oh its a breaking change in the release we may bump to, maybe we should make a heads up announcement on discourse/mybinder.org before we merge this bump PR?"

@minrk
Copy link
Member

minrk commented Jun 13, 2023

Announcement on the forum

@minrk
Copy link
Member

minrk commented Jun 13, 2023

and banner for mybinder.org: jupyterhub/mybinder.org-deploy#2665

@yuvipanda
Copy link
Collaborator Author

Conversation in jupyterhub/mybinder.org-deploy#2663 has come to a conclusion to continue current practice. I think there's been enough lead time now! Anyone wanna hit the merge button? :)

@consideRatio consideRatio changed the title Upgrade base image to Ubuntu 22.04 Upgrade base image from Ubuntu 18.04 to Ubuntu 22.04 Aug 8, 2023
@consideRatio consideRatio changed the title Upgrade base image from Ubuntu 18.04 to Ubuntu 22.04 Upgrade base image from to Ubuntu 22.04 from 18.04 Aug 8, 2023
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I locally merged this on my computer and searched for 18.04, 20.04, bionic, focal, and found no outdated references besides one now fixed - this LGTM and seems ready for merge!

@manics
Copy link
Member

manics commented Aug 8, 2023

@vishwa2710
Copy link

Hi all! Wondering if this is going to get merged anytime soon?

@consideRatio
Copy link
Member

@yuvipanda @minrk @manics I went for a merge here. I verified that the tests still passed against the latest main branch.

@consideRatio consideRatio merged commit 3fe6c75 into jupyterhub:main Sep 18, 2023
32 checks passed
@yuvipanda
Copy link
Collaborator Author

Yay, thanks @consideRatio :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking maintenance Under the hood fixes and improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to a more recent version : repo2docker/buildpacks/base.py l:16 FROM buildpack-deps:bionic
6 participants