Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: let dependabot update used GitHub action's versions #1949

Merged
merged 2 commits into from Dec 18, 2020

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Dec 17, 2020

It seems that dependabot can keep our workflows used GitHub actions' versions, so I figure why not!

Comment on lines +12 to +13
- maintenance
- dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is overriding the default dependabot labels:
https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/customizing-dependency-updates#setting-custom-labels

Are we using them for a particular purpose, or could we remove this bit of the config and rely on the defaults?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting to know! Hmm want github-activity to sort these PR quickly when generating a changelog, which based on current github-activity function means the maintenance label.

Id like a dedicated category for dependencies etc, but at this point its maintenance.

Can we add extra labels in a hardcoded way instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that's fine 😀. Just wanted to check it's an intentional override.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) thanks for review @manics! Merge?

.github/dependabot.yaml Outdated Show resolved Hide resolved
@consideRatio consideRatio changed the title ci: let dependabot update GitHub action version ci: let dependabot update used GitHub action's versions Dec 18, 2020
@manics manics merged commit abaceaf into jupyterhub:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants