-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: let dependabot update used GitHub action's versions #1949
Merged
manics
merged 2 commits into
jupyterhub:master
from
consideRatio:pr/dependabot-gha-maintenance
Dec 18, 2020
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,22 @@ | ||
| # dependabot.yml reference: https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/configuration-options-for-dependency-updates | ||
| version: 2 | ||
| updates: | ||
| # Automatically update python packages for the jupyterhub/k8s-hub image | ||
| - package-ecosystem: pip | ||
| directory: "/images/hub" | ||
| schedule: | ||
| interval: daily | ||
| open-pull-requests-limit: 4 | ||
| versioning-strategy: lockfile-only | ||
| labels: | ||
| - maintenance | ||
| - dependencies | ||
| commit-message: | ||
| prefix: "hub image: " | ||
| # Maintain Python dependencies for the jupyterhub/k8s-hub image | ||
| - package-ecosystem: pip | ||
| directory: "/images/hub" | ||
| schedule: | ||
| interval: daily | ||
| open-pull-requests-limit: 4 | ||
| versioning-strategy: lockfile-only | ||
| labels: | ||
| - maintenance | ||
| - dependencies | ||
|
|
||
| # Maintain dependencies in our GitHub Workflows | ||
| - package-ecosystem: "github-actions" | ||
| directory: "/" # This should be / rather than .github/workflows | ||
| schedule: | ||
| interval: daily | ||
| labels: | ||
| - maintenance | ||
| - dependencies | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is overriding the default dependabot labels:
https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/customizing-dependency-updates#setting-custom-labels
Are we using them for a particular purpose, or could we remove this bit of the config and rely on the defaults?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting to know! Hmm want github-activity to sort these PR quickly when generating a changelog, which based on current github-activity function means the maintenance label.
Id like a dedicated category for dependencies etc, but at this point its maintenance.
Can we add extra labels in a hardcoded way instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that's fine 😀. Just wanted to check it's an intentional override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:) thanks for review @manics! Merge?