Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invalid styling for inputs #84

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Add invalid styling for inputs #84

merged 5 commits into from
Jan 4, 2024

Conversation

fcollonval
Copy link
Member

Add invalid styling through the attribute aria-invalid="true" for user input elements.

Add invalid to combobox

Add errorMessage to date-field

Add errorMessage to number field

Add errorMessage to radio

Add error message to radio group

Add errorMessage to search

Add errorMessage to select

Add errorMessage to slider

Add errorMessage to switch

Add errorMessage to text area

Add errorMessage to text field

Align stories arg name and element attribute

Add new attribute to react props

Add visual test for error message
@fcollonval fcollonval added the enhancement New feature or request label Jan 3, 2024
Copy link

github-actions bot commented Jan 3, 2024

Binder 👈 Launch a Binder on branch jupyterlab-contrib/jupyter-ui-toolkit/ft/add-error-msg

@fcollonval fcollonval merged commit 47f59e1 into main Jan 4, 2024
8 of 9 checks passed
@fcollonval fcollonval deleted the ft/add-error-msg branch January 4, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant