Update jupyter_theme_editor for jupyterlab 4 using the migration script. #13
Conversation
|
|
.copier-answers.yml
Outdated
There was a problem hiding this comment.
Looks like this file should be removed since it was used for generating the template.
_temp_extension/.copier-answers.yml
Outdated
There was a problem hiding this comment.
The whole _temp_extension folder can be removed.
Most likely this is used by the migration script to generate a new version of the extension before proceeding with the migration.
style/base.css
Outdated
There was a problem hiding this comment.
Looks like this file should be kept. Maybe it's an issue with the migration script that deleted it?
schema/plugin.json
Outdated
There was a problem hiding this comment.
Looks like the migration script might have removed the settings by mistake.
I think it should be fine to keep the previous version of the file (like it was before).
HaudinFlorence
force-pushed
the
update_with_extension_migration_script
branch
2 times, most recently
from
99e0d33
to
a47fdf1
Compare
HaudinFlorence
force-pushed
the
update_with_extension_migration_script
branch
from
a47fdf1
to
ec72bdb
Compare
jupyter_theme_editor/handlers.py
Outdated
| base_url, 'jupyter-theme-editor', "send_cssProperties") | ||
| handlers = [(route_pattern, RouteHandler, {"env":Environment(loader=PackageLoader( | ||
| "jupyter_theme_editor", "templates")), "path": "template.css" })] | ||
| route_pattern = url_path_join(base_url, "jupyter-theme-editor", "get-example") |
There was a problem hiding this comment.
Looks like the API endpoint has changed with the update?
There was a problem hiding this comment.
Maybe replacing get-example with send_cssProperties will help fix it.
Update jupyter_theme_editor for jupyterlab 4 using the migration script.