-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change dict loading mechanism from internal static to server extension #74
Change dict loading mechanism from internal static to server extension #74
Conversation
4eccbc0
to
9c28e7d
Compare
7642c9c
to
775a0b3
Compare
This looks good! I agree to look for dictionaries manually, without a lang.json file. But how can we implement a language description which is able to load files directly from the network? With lang.json this is easy, okay, one can argue "download everything you need" is sufficient ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good :-)
I have mixed feelings here. I did think about making another setting for "online dictionaries" so that one would go to the advanced settings and add something like: {
"ignore": ["JupyterLab", "Notebook", "Notatnik"],
"language": "pl_PL-online",
"onlineDictionaries": [
{
"id": "pl_PL-online",
"aff": "http://some-url/pl_PL.aff",
"dic": "http://some-url/pl_PL.dic",
"name": "polski (Polska)"
}
]
} I'm not convinced that this is necessary now, given that the dictionaries loaded locally to the disk are more reliable, but I see that for some very specific use cases this might be useful. I will open a new issue to track this one. |
Builds upon #70
Closes #31
babel
to resolve the language/locale name for given locale code (as it is already a dependency of JupyterLab) - we can revisit this in the futureIn the follow up PR: split the existing dictionaries into separate packages so that one does not need to install the dictionaries they don't need