Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Support for alternate JupyterLab distributions #69

Closed
jtpio opened this issue Jul 5, 2021 · 0 comments
Closed

Support for alternate JupyterLab distributions #69

jtpio opened this issue Jul 5, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@jtpio
Copy link
Member

jtpio commented Jul 5, 2021

Problem

It would be great if galata could also be used to test alternative JupyterLab distributions such as RetroLab.

Proposed Solution

At the moment it looks like the default page hits the /lab endpoint:

let jlabUrl = path.join(baseUrl, 'lab');

There is also this setup logic using /lab by default:

let resourcePath = '/lab';
if (context.jlabWorkspace) {
resourcePath = `${resourcePath}/workspaces/${context.jlabWorkspace}`;
}
await context.page.evaluate(async resourcePath => {
await window.galataip.waitForLaunch(resourcePath);
}, resourcePath);

Additional context

A potential candidate for this would be RetroLab: jupyterlab/retrolab#135

@jtpio jtpio added the enhancement New feature or request label Jul 5, 2021
fcollonval added a commit to fcollonval/jupyterlab that referenced this issue Aug 24, 2021
fcollonval added a commit to fcollonval/jupyterlab that referenced this issue Aug 25, 2021
fcollonval added a commit to fcollonval/jupyterlab that referenced this issue Aug 26, 2021
Homogeneous version

Fix tests

WIP drop jest

WIP playwright

First working version

WIP mock state and settings

Use node-fetch instead of axios

Add temporary server test folder fixture

Remove html report assets

Track sessions and terminals related to a test

Finalize notebook tests

Set up CI

Don't use a single worker by default

Delete data.csv

Increase timeout to wait for JLab in dev-mode

Build the galata assets before the tests

Install chromium

Upload galata artifacts

Bump playwright test runner

enhance settings fixture

Correct tests

Fix integrity

Split assests into two artifacts

Fix regex and settings setting

Fix mockSettings test

WIP Convert contextmenu tests

galata refactoring

All contents helpers use the REST API

Correct linter ignore files

Correct contextmenu test

Migrate debugger tests

Start converting general tests

Convert general tests

convert notebook-run

Improve temporary server folder name

Convert toc tests

Convert notebook create

Convert notebook-edit

Convert notebook-toolbar

Improve test:report
Open browser
Don't expose local port

Fix galata tests

Improve test partitioning for sessions and terminals

Use Playwright project feat. to merge galata and ui-tests

Update test using project structure

Fix jupyterlab/galata#69

Upgrade newly added tests

Add install

Fix build inpage

Fix tests

More fix

Try to fix typedoc

Update reference screenshots

Use galata.newContentsHelper

More robust `page.waitIsReady`

Fix types for typedoc

Revert change for integrity testing

Auto review
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant