Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor stays in the previous after executing with Shift-Enter #137

Open
jtpio opened this issue Apr 4, 2023 · 5 comments
Open

Cursor stays in the previous after executing with Shift-Enter #137

jtpio opened this issue Apr 4, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@jtpio
Copy link
Member

jtpio commented Apr 4, 2023

Description

Reproduce

  • Open browser tabs
  • Type some code in one of them
  • Press Shift-Enter
  • This automatically creates a new cell below
  • See how the cursor stays in the first cell in the other tab

10-rtc

Expected behavior

The cursor should be shown in the second cell.

Context

This was found while looking into jupyter/notebook#6816.

On the screencast above, the browser on the left is Chromium, the one on the right is Firefox.

@jtpio jtpio added the bug Something isn't working label Apr 4, 2023
@krassowski
Copy link
Member

Looks related or the same as jupyterlab/jupyterlab#14271

Maybe we are not notifying code mirror correctly about leaving the cell editor?

@davidbrochart
Copy link
Collaborator

Maybe I'm not getting the issue, but isn't it the normal behavior that another user cannot move my cursor?
Even if they create a new cell and move their cursor in it, I'm not expecting my cursor to move into this new cell.
Am I missing something?

@krassowski
Copy link
Member

maybe collaborator cursors should be visually distinct (beyond colour) to prevent confusion? In 3.x we had a needle pin on collaborator cursors, could we bring this back?

@jtpio
Copy link
Member Author

jtpio commented Apr 5, 2023

Maybe I'm not getting the issue, but isn't it the normal behavior that another user cannot move my cursor? Even if they create a new cell and move their cursor in it, I'm not expecting my cursor to move into this new cell. Am I missing something?

The issue here is that the cursor does not follow. See the beginning of screencast:

  • left: collaborator executes import this with shift enter and their cursor is on the second cell (expected)
  • right: the blue cursor is still in the first cell, the one with import this as the content (unexpected)

@davidbrochart
Copy link
Collaborator

Oh I get it now, thanks @krassowski !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants