Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Node 10+ to work with JupyterLab 2.1 #8083

Closed
afshin opened this issue Mar 25, 2020 · 4 comments · Fixed by #8112
Closed

Enable Node 10+ to work with JupyterLab 2.1 #8083

afshin opened this issue Mar 25, 2020 · 4 comments · Fixed by #8112
Assignees
@afshin
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Build System
Milestone
2.1

Comments

@afshin
Copy link
Member

afshin commented Mar 25, 2020

We currently require Node 12+ but we should re-enable Node 10+.
@afshin afshin added this to the 2.1 milestone Mar 25, 2020
@jasongrout
Copy link
Contributor

See #7677

@jasongrout
Copy link
Contributor

From #7677 - the situation now (I think) is that we do support node <12, just that many users will need to set the max memory node options variable.

@afshin afshin self-assigned this Mar 25, 2020
@saulshanabrook
Copy link
Member

So next step is to revert changes in that PR

@afshin afshin mentioned this issue Mar 28, 2020
Merged
@afshin
Copy link
Member Author

afshin commented Mar 28, 2020

Fixed in #8112

@afshin afshin closed this as completed Mar 28, 2020
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@afshin afshin

Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Build System
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

Revert #7677
3 participants
@afshin @jasongrout @saulshanabrook