-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update benchmark reporter snapshots #15279
Update benchmark reporter snapshots #15279
Conversation
Thanks for making a pull request to jupyterlab! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @krassowski
Merging it directly to fix CI as the two remaining workflows in progress are not impacted by this.
@meeseeksdev please backport to 4.0.x |
@meeseeksdev please backport to 3.6.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
It looks like the backport to 3.6.x will not be needed since we are not backporting #15270 (which cause the change) as far, but if we do then one can grab the backport draft from my |
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
References
CI on a few pull requests, e.g.:
started failing yesterday due to a negligible change in SVGs generated.
Code changes
Updates SVG snapshots
User-facing changes
None
Backwards-incompatible changes
None