Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmark reporter snapshots #15279

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

krassowski
Copy link
Member

References

CI on a few pull requests, e.g.:

started failing yesterday due to a negligible change in SVGs generated.

Code changes

Updates SVG snapshots

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krassowski

Merging it directly to fix CI as the two remaining workflows in progress are not impacted by this.

@fcollonval fcollonval merged commit 1728207 into jupyterlab:main Oct 19, 2023
78 of 81 checks passed
@fcollonval
Copy link
Member

@meeseeksdev please backport to 4.0.x

@fcollonval
Copy link
Member

@meeseeksdev please backport to 3.6.x

@lumberbot-app
Copy link

lumberbot-app bot commented Oct 19, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 3.6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 1728207ffbad5baea1e77e4005230632bf6f16a6
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #15279: Update benchmark reporter snapshots'
  1. Push to a named branch:
git push YOURFORK 3.6.x:auto-backport-of-pr-15279-on-3.6.x
  1. Create a PR against branch 3.6.x, I would have named this PR:

"Backport PR #15279 on branch 3.6.x (Update benchmark reporter snapshots)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@krassowski
Copy link
Member Author

It looks like the backport to 3.6.x will not be needed since we are not backporting #15270 (which cause the change) as far, but if we do then one can grab the backport draft from my backport-of-pr-15279-on-3.6.x branch.

fcollonval pushed a commit that referenced this pull request Oct 25, 2023
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants