Fix usage check job on CI (add setuptools dependency)
#16423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
krassowski
changed the title
setuptools dependency)
fcollonval
approved these changes
Jun 4, 2024
|
@meeseeksdev please backport to 4.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jun 4, 2024
…ols` dependency)
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jun 4, 2024
…ols` dependency)
jtpio
added a commit
that referenced
this pull request
Jun 4, 2024
…dency) (#16428) Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
jtpio
added a commit
that referenced
this pull request
Jun 4, 2024
…dency) (#16429) Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #16404
Since
setuptoolsis used here:jupyterlab/jupyterlab/federated_labextensions.py
Line 464 in 21ffea9
There should likely be a direct dependency on it.
It's possible it was assumed
setuptoolswould be available via one of the dependency, and such dependency does not require it anymore (although not sure which one).Code changes
Add the
setuptools>=40.1.0dependency.From : #16404 (comment)
User-facing changes
None
Backwards-incompatible changes
None