Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook 4.3 Shim #5252

Merged
merged 5 commits into from
Aug 31, 2018
Merged

Notebook 4.3 Shim #5252

merged 5 commits into from
Aug 31, 2018

Conversation

blink1073
Copy link
Contributor

Fixes #5246

@blink1073 blink1073 added the bug label Aug 31, 2018
@blink1073 blink1073 added this to the 0.34.x milestone Aug 31, 2018
@blink1073 blink1073 merged commit 3201e47 into jupyterlab:master Aug 31, 2018
@blink1073
Copy link
Contributor Author

Released as 0.34.7.

blink1073 added a commit that referenced this pull request Aug 31, 2018
* Add shim for old notebooks and test against old notebooks

* update note

* use 4.3.1

* No action

* Always on if no config
@jasongrout
Copy link
Contributor

Thank you very much!

@blink1073 blink1073 deleted the notebook-4.3-shim branch September 4, 2018 09:42
@jasongrout jasongrout modified the milestones: 0.34.x, 0.35 Oct 1, 2018
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

labapp.py # AttributeError: 'LabApp' object has no attribute 'quit_button'
2 participants