Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds package installation info to labextension list and uninstall output #9244

Merged
merged 6 commits into from Oct 30, 2020
Merged

Adds package installation info to labextension list and uninstall output #9244

merged 6 commits into from Oct 30, 2020

Conversation

jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Oct 29, 2020 •
edited

References

Fixes (along with other PRs) #9231

Includes #9232

Code changes

This adds the info supplied by jupyterlab/jupyterlab_server#132 to the jupyter labextension list and jupyter labextension uninstall commands.

User-facing changes

The users understand better how extensions were installed and how to uninstall them.

% jupyter labextension uninstall @jupyter-widgets/jupyterlab-manager
JupyterLab cannot uninstall this extension. Use your Python package manager (pip, conda, etc.) to uninstall the package jupyterlab_widgets

% jupyter labextension list
JupyterLab v3.0.0rc6
/[snip]/share/jupyter/labextensions
        jupyterlab_apod v0.1.0 enabled OK (python, jupyterlab_apod)
        @jupyter-widgets/jupyterlab-manager v3.0.0-alpha.2 enabled OK (python, jupyterlab_widgets)

Backwards-incompatible changes

@jasongrout
Refuse to uninstall federated extensions.
e6ed7a5 
Since we did not install the federated extension, we should not be uninstalling it and deleting files from other packages and installation systems.

Fixes jupyterlab#9230

See more discussion at jupyterlab#9231.
@jasongrout
Move the federated check back up to the top of the uninstall code.
82db529 
Since federated extensions mask other extensions, we should error out right away if there is a federated extension. Otherwise, we might uninstall the hidden extension the federated extension is masking.
@jasongrout
Use a set for set-like operations
f02ee53
@jasongrout
federated_exts -> federated_extensions for consistency
dea9cdc
@jasongrout
Add installation metadata messages to jupyter labextension uninstall …
84e2ceb 
…and list.
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

This was referenced Oct 29, 2020
Closed
Merged
@jasongrout jasongrout added this to the 3.0 milestone Oct 29, 2020
@jasongrout jasongrout added this to In progress in Extension System rework via automation Oct 29, 2020
jtpio
jtpio approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

blink1073
blink1073 approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 792d420 into jupyterlab:master Oct 30, 2020
Extension System rework automation moved this from In progress to Done Oct 30, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Apr 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtpio jtpio jtpio approved these changes

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
No open projects
Extension System rework
  
Done
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jasongrout @jtpio @blink1073