Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for newer openapi spec #360

Merged
merged 4 commits into from
Dec 24, 2022

Conversation

blink1073
Copy link
Contributor

Fixes #359

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2022

Codecov Report

Base: 80.88% // Head: 81.05% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (8594a27) compared to base (dfd340f).
Patch coverage: 89.15% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   80.88%   81.05%   +0.17%     
==========================================
  Files          22       22              
  Lines        1700     1737      +37     
  Branches      323      334      +11     
==========================================
+ Hits         1375     1408      +33     
- Misses        225      227       +2     
- Partials      100      102       +2     
Impacted Files Coverage Δ
jupyterlab_server/spec.py 86.66% <60.00%> (-7.09%) ⬇️
jupyterlab_server/test_utils.py 75.00% <91.02%> (+7.92%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 merged commit 1f552fd into jupyterlab:main Dec 24, 2022
@blink1073 blink1073 deleted the update-openapi branch December 24, 2022 03:30
@blink1073
Copy link
Contributor Author

I'll release this next week.

# openapi_core 0.15.0 alpha is not working
"openapi_core~=0.14.2",
"openapi-spec-validator<0.6",
"openapi_core>=0.16.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, but perhaps we keep it DRYer with jupyterlab_server[openapi]

@lresende
Copy link
Member

Why this is forcing jsonschema>=4.17.3 while the openapi requires only jsonschema[format]>=2.6.0 ?

If nothing specific, could we revert back to a more flexible requirement here jsonschema>=3.0.1, particularly as packages will usually cap on the next major release and we suddenly moved from 3.0.1 as the minimum to 4.17.13 the latest?

@blink1073 @marthacryan

@blink1073
Copy link
Contributor Author

openapi-spec-validator requires it.

lresende added a commit to lresende/jupyterlab_server that referenced this pull request Feb 13, 2023
- Currently various external dependencies caps jsonschema on the
next major release, and we jumped from requiring jsonschema 2.6.0
to 4.17.3 on jupyterlab#360 and that is causing a lot of incompatibility in
the ecosystem.

- This reduces the requirement to 3.2.0 which is also the minimun
required by jupyter-events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to latest openapi-spec-validator
4 participants