-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for newer openapi spec #360
Conversation
Codecov ReportBase: 80.88% // Head: 81.05% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
+ Coverage 80.88% 81.05% +0.17%
==========================================
Files 22 22
Lines 1700 1737 +37
Branches 323 334 +11
==========================================
+ Hits 1375 1408 +33
- Misses 225 227 +2
- Partials 100 102 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I'll release this next week. |
# openapi_core 0.15.0 alpha is not working | ||
"openapi_core~=0.14.2", | ||
"openapi-spec-validator<0.6", | ||
"openapi_core>=0.16.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit, but perhaps we keep it DRYer with jupyterlab_server[openapi]
Why this is forcing If nothing specific, could we revert back to a more flexible requirement here |
|
- Currently various external dependencies caps jsonschema on the next major release, and we jumped from requiring jsonschema 2.6.0 to 4.17.3 on jupyterlab#360 and that is causing a lot of incompatibility in the ecosystem. - This reduces the requirement to 3.2.0 which is also the minimun required by jupyter-events
Fixes #359