Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling language packs for pseudo language #456

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Fix handling language packs for pseudo language #456

merged 2 commits into from
Jul 16, 2024

Conversation

fcollonval
Copy link
Member

Fix handling the language pack for the pseudo-language allowing in-app translation.

Needed by https://github.com/jupyterlab-contrib/in-context-translation

@fcollonval fcollonval added the bug label Jul 14, 2024
@fcollonval fcollonval mentioned this pull request Jul 14, 2024
Merged
krassowski
krassowski approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I would consider whether PSEUDO_LANGUAGE should be accepted by is_valid_locale, but current implementation works fine too.

@fcollonval fcollonval merged commit cac303a into jupyterlab:main Jul 16, 2024
27 of 28 checks passed
@fcollonval fcollonval deleted the fix/support-pseudo-language branch July 17, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krassowski krassowski krassowski approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcollonval @krassowski