Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Snapshot Action: fix handling of the browser option #183

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Feb 10, 2023

The browser input did not seem to be used.

  • Allow installing a specific browser or all of them by default
  • Pass the browser to the update_script

@jtpio
Copy link
Member Author

jtpio commented Feb 10, 2023

Need to double check how --browser is handled when left empty.

@krassowski
Copy link
Member

I think this is an improvement as-is. This fixes #183. Should we merge?

@jtpio
Copy link
Member Author

jtpio commented Apr 17, 2023

I think it's still a draft because it wasn't clear how Playwright would handle the empty ('') default parameter with --browser ${{ inputs.browser }}.

Not sure I'll have the bandwith to get back to it in the coming days, so if you would like to pick up this PR then feel free, thanks!

@krassowski
Copy link
Member

Allow installing a specific browser or all of them by default

I am not sure if we ever need to test all browsers in a single run of the action. If we want to test on multiple browsers we would likely split these into multiple runs anyways so that it is easier to rerun flaky jobs.

@jtpio jtpio marked this pull request as ready for review September 5, 2023 13:17
@jtpio
Copy link
Member Author

jtpio commented Sep 5, 2023

Thanks @krassowski for the review.

If we want to test on multiple browsers we would likely split these into multiple runs anyways so that it is easier to rerun flaky jobs.

Yes makes sense to use a test matrix.

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtpio @krassowski I guess this is ok to be merged, isn't it?

@jtpio
Copy link
Member Author

jtpio commented Oct 3, 2023

Yes it should be to good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants