Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Start ui-tests #167

Merged
merged 24 commits into from
Oct 13, 2023
Merged

Start ui-tests #167

merged 24 commits into from
Oct 13, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 5, 2023

Fixes #29

  • Add ui-tests top-level folder
  • Test on chromium and firefox
  • Snapshot test to check the kernel is correctly registered
  • Test execute code
  • Test access files
  • Try webkit to investigate Safari Support #152 -> will try in a separate PR
  • Add workflow to update snapshots

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

lite-badge 👈 Try it on ReadTheDocs

@jtpio
Copy link
Member Author

jtpio commented Oct 13, 2023

Deferring the webkit investigation to a separate PR.

@jtpio jtpio marked this pull request as ready for review October 13, 2023 08:41
@@ -5,3 +5,6 @@ coverage
tests
src/worker.ts
src/web_worker_kernel.ts

# TODO: remove
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I missed this one.

Happy to track it in a separate issue to not block this PR if that's fine.

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks

ui-tests/test/general.test.ts Outdated Show resolved Hide resolved
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 886b9a4 into jupyterlite:main Oct 13, 2023
12 checks passed
@jtpio jtpio deleted the ui-tests branch October 13, 2023 09:22
This was referenced Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UI-tests
2 participants