Fix order of kernels in UI tests #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpio
commented
Mar 29, 2024
| @@ -2,6 +2,7 @@ | |||
| "jupyter-lite-schema-version": 0, | |||
| "jupyter-config-data": { | |||
| "appName": "JupyterLite UI Tests", | |||
| "defaultKernelName": "xlua", | |||
There was a problem hiding this comment.
@martinRenou @DerThorsten is there anything in xeus-lua or xeus-python that could explain the sudden change noticed in #83 (comment) ?
There was a problem hiding this comment.
It could have been the new JupyterLite 0.3.0, but it looks pinning down in #84 (comment) produces the same outcome.
|
I guess we can live with this for now if it helps fix the CI, and track that in an issue to have a look later. |
|
This would unblock other pending PRs. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83
Troubleshooting in #84 didn't lead to explanations.
But setting the default kernel name explicitly might help.