Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for new GraphicsView #630

Merged
merged 131 commits into from
Oct 20, 2023
Merged

Conversation

jdpurcell
Copy link
Contributor

For your graphicsview-rewrite branch:

  • I merged in the latest official master, taking care of any conflicts (wasn't as bad as I expected).
  • I cherry-picked any newer relevant changes from my master, mostly related to Pictures are scaled above window size (some pixels) #627 (no settings UI changes included). There were more conflicts than expected because we changed some of the zoom-to-fit stuff in your branch (the separate "Resize Resets Zoom" option), but I took care of it.

jdpurcell and others added 30 commits January 13, 2023 23:06
Window sizing/positioning fixes
Fix file index misdetection due to Unicode normalization issues
CI: Update OpenSSL download link
Currently translated at 81.2% (217 of 267 strings)

Translation: qView/qView
Translate-URL: https://hosted.weblate.org/projects/qview/qview/nb_NO/
Currently translated at 100.0% (267 of 267 strings)

Translation: qView/qView
Translate-URL: https://hosted.weblate.org/projects/qview/qview/es/
Currently translated at 100.0% (267 of 267 strings)

Translation: qView/qView
Translate-URL: https://hosted.weblate.org/projects/qview/qview/es/
Currently translated at 100.0% (267 of 267 strings)

Translation: qView/qView
Translate-URL: https://hosted.weblate.org/projects/qview/qview/uk/
Currently translated at 83.1% (222 of 267 strings)

Translation: qView/qView
Translate-URL: https://hosted.weblate.org/projects/qview/qview/ko/
Currently translated at 100.0% (267 of 267 strings)

Translation: qView/qView
Translate-URL: https://hosted.weblate.org/projects/qview/qview/ko/
Fix cache using more memory than intended
Currently translated at 81.2% (217 of 267 strings)

Translation: qView/qView
Translate-URL: https://hosted.weblate.org/projects/qview/qview/nb_NO/
Currently translated at 100.0% (267 of 267 strings)

Translation: qView/qView
Translate-URL: https://hosted.weblate.org/projects/qview/qview/es/
Currently translated at 100.0% (267 of 267 strings)

Translation: qView/qView
Translate-URL: https://hosted.weblate.org/projects/qview/qview/es/
jdpurcell and others added 26 commits August 25, 2023 22:06
This occurred with "window matches image size" set to "when opening images".
Fix window getting unmaximized/resized when exiting full screen mode.
Workaround for slow font loading on Windows
When "window matches image size" changes, enable/disable size controls
And correct for rounding error that made the image jump around more than necessary when resizing window
To match code style of the fork in which this has a settings UI entry
The desired size already has the correct aspect ratio; any further adjustment by Qt could cause the size to be off a pixel or so from what we want.
Calculated aspect ratio was slightly off in some cases. Also enforce minimum window size in both dimensions.
Not sure if this use case was intentional in qView, but regardless it exists and people have gotten used to it.
@jurplel jurplel self-requested a review October 7, 2023 19:40
@jurplel
Copy link
Owner

jurplel commented Oct 20, 2023

Oh man, sorry I left this waiting for so long. I will blindly merge this for now!

@jurplel jurplel merged commit 8eb7d68 into jurplel:graphicsview-rewrite Oct 20, 2023
6 checks passed
@jdpurcell jdpurcell deleted the gvr-mm branch March 2, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.