Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease the size of reference id #143

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Decrease the size of reference id #143

merged 3 commits into from
Aug 25, 2023

Conversation

ashi20192020
Copy link
Contributor

@ashi20192020 ashi20192020 commented Aug 25, 2023

Fixes https://app.asana.com/0/0/1205266049614195/f

  • Implemented code to decrease size of reference id
  • Replaced pallet-insecure-randomness-collective-flip with frame-support-test for testing randomness in test-cases according to Substrate best practices
  • Migration to modify existing reference id

Copy link
Collaborator

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR lacks rationale and relation with bugs/asana stories

@ashi20192020
Copy link
Contributor Author

ashi20192020 commented Aug 25, 2023

This PR lacks rationale and relation with bugs/asana stories

@alessio I have updated ticket description.

Copy link
Collaborator

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my comments and I'll approve. Still pending @Polkaverse's review.

@ashi20192020
Copy link
Contributor Author

Please address my comments and I'll approve. Still pending @Polkaverse's review.

Done @alessio . Please check and approve

@alessio alessio merged commit 3f8cbb6 into develop Aug 25, 2023
1 check passed
@alessio alessio deleted the reference_id branch August 25, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants