Added a new function for conditional access to db #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/EulerHS/KVConnector/Flow.hs
Outdated
| let findAllQueryUpdated = DB.findRows (sqlSelect ! #where_ whereClause ! defaults) | ||
| dbRes <- runQuery dbConf findAllQueryUpdated | ||
| case dbRes of | ||
| Right dbRows -> pure $ Right $ matchedKVLiveRows ++ getUniqueDBRes dbRows (snd kvRows) |
There was a problem hiding this comment.
why returning KVrows after doing DB call?
enigma-commits
force-pushed
the
EulerHd/New-function-for-fetching-entries-from-kv-only-with-conditional-db
branch
from
7287d3e
to
c20fc31
Compare
src/EulerHS/KVConnector/Flow.hs
Outdated
| Right kvRows -> do | ||
| let matchedKVLiveRows = findAllMatching whereClause (fst kvRows) | ||
| matchedKVRowsLength = length matchedKVLiveRows | ||
| if matchedKVRowsLength >= 1 |
There was a problem hiding this comment.
use null function rather than length
enigma-commits
force-pushed
the
EulerHd/New-function-for-fetching-entries-from-kv-only-with-conditional-db
branch
from
c20fc31
to
ec345c8
Compare
aravindgopall
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new function for getting elements from KV if any of the entry is present else looking into db.
Generated SQL function for respective function.
SELECT t0.id AS res0, t0.tag AS res1, t0.location_id AS res2, t0.entity_id AS res3, t0.order AS res4, t0.version AS res5 FROM atlas_driver_offer_bpp.location_mapping AS t0 WHERE (t0.entity_id) = ('a9916d39-a7dc-4c83-b76a-9cf46445e0bf')