Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enhance filters ui #1038

Merged
merged 7 commits into from
Jul 25, 2024
Merged

fix: enhance filters ui #1038

merged 7 commits into from
Jul 25, 2024

Conversation

gitanjli525
Copy link
Contributor

@gitanjli525 gitanjli525 commented Jul 22, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

CURRENT

image

image

NEW

image

image

image

Motivation and Context

How did you test it?

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@gitanjli525 gitanjli525 self-assigned this Jul 22, 2024
@gitanjli525 gitanjli525 requested a review from a team as a code owner July 22, 2024 10:10
@gitanjli525 gitanjli525 linked an issue Jul 22, 2024 that may be closed by this pull request
[BUG] filters breaking in front end #995
Closed
@gitanjli525 gitanjli525 changed the title chore: enhance filters ui fix: enhance filters ui Jul 22, 2024
@gitanjli525 gitanjli525 added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 22, 2024
JeevaRamu0104
JeevaRamu0104 previously approved these changes Jul 22, 2024
View reviewed changes
Riddhiagrawal001
Riddhiagrawal001 requested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@Riddhiagrawal001 Riddhiagrawal001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make all the buttons aligned ? As the two looks a bit more in width
image

@gitanjli525
Copy link
Contributor Author

Done @Riddhiagrawal001
image

@gitanjli525
Copy link
Contributor Author

gitanjli525 commented Jul 22, 2024 •
edited
Loading

After merging main:

image
image

@Riddhiagrawal001
Copy link
Contributor

We had to change the color of the Generate sample data button and delete sample data to white . Can we also incorporate in this one ?

@JeevaRamu0104 JeevaRamu0104 added this pull request to the merge queue Jul 25, 2024
Merged via the queue into main with commit 7343036 Jul 25, 2024
5 of 6 checks passed
@JeevaRamu0104 JeevaRamu0104 deleted the filters-ui-enhance branch July 25, 2024 08:52
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Riddhiagrawal001 Riddhiagrawal001 Riddhiagrawal001 approved these changes

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

@sagarnaikjuspay sagarnaikjuspay sagarnaikjuspay approved these changes

Assignees

@gitanjli525 gitanjli525

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] filters breaking in front end
5 participants
@gitanjli525 @Riddhiagrawal001 @PritishBudhiraja @JeevaRamu0104 @sagarnaikjuspay