Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filters enhance #160

Merged
merged 16 commits into from
Jan 9, 2024
Merged

fix: filters enhance #160

merged 16 commits into from
Jan 9, 2024

Conversation

sagarnaikjuspay
Copy link
Contributor

@sagarnaikjuspay sagarnaikjuspay commented Jan 3, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Motivation and Context

How did you test it?

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@sagarnaikjuspay sagarnaikjuspay self-assigned this Jan 3, 2024
@sagarnaikjuspay sagarnaikjuspay requested a review from a team as a code owner January 3, 2024 10:45
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 3, 2024
@sagarnaikjuspay sagarnaikjuspay changed the title Filters enhance feat: filters enhance Jan 3, 2024
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 3, 2024
@JeevaRamu0104 JeevaRamu0104 added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Jan 4, 2024
PritishBudhiraja
PritishBudhiraja requested changes Jan 4, 2024
View reviewed changes
src/components/DateRangePicker.res Outdated Show resolved Hide resolved
src/screens/HyperSwitch/HSwitchRemoteFilter.res Outdated Show resolved Hide resolved
src/screens/HyperSwitch/HSwitchRemoteFilter.res Outdated Show resolved Hide resolved
@sagarnaikjuspay sagarnaikjuspay added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jan 5, 2024
@JeevaRamu0104 JeevaRamu0104 added S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jan 8, 2024
@sagarnaikjuspay sagarnaikjuspay linked an issue Jan 8, 2024 that may be closed by this pull request
fix: filter issue of payment list #186
Closed
@JeevaRamu0104 JeevaRamu0104 changed the title feat: filters enhance fix: filters enhance Jan 8, 2024
@sagarnaikjuspay sagarnaikjuspay added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels Jan 8, 2024
@JeevaRamu0104 JeevaRamu0104 added S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jan 8, 2024
@sagarnaikjuspay sagarnaikjuspay added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels Jan 8, 2024
@JeevaRamu0104 JeevaRamu0104 added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jan 9, 2024
@JeevaRamu0104 JeevaRamu0104 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jan 9, 2024
@JeevaRamu0104 JeevaRamu0104 added this pull request to the merge queue Jan 9, 2024
Merged via the queue into main with commit 77cebce Jan 9, 2024
5 checks passed
@PritishBudhiraja PritishBudhiraja deleted the filters-enhance branch January 17, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

@Riddhiagrawal001 Riddhiagrawal001 Riddhiagrawal001 approved these changes

@PritishBudhiraja PritishBudhiraja PritishBudhiraja left review comments

Assignees

@sagarnaikjuspay sagarnaikjuspay

Labels
S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: filter issue of payment list
4 participants
@sagarnaikjuspay @Riddhiagrawal001 @PritishBudhiraja @JeevaRamu0104