Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pay now button text & theme based changes #223

Merged
merged 8 commits into from
Mar 13, 2024
Merged

fix: pay now button text & theme based changes #223

merged 8 commits into from
Mar 13, 2024

Conversation

PritishBudhiraja
Copy link
Collaborator

@PritishBudhiraja PritishBudhiraja commented Mar 12, 2024

Pay Now Button Text & theme based changes

akash-c-k
akash-c-k previously approved these changes Mar 12, 2024
@PritishBudhiraja PritishBudhiraja changed the title fix: pay now button text fix: pay now button text & theme based changes Mar 12, 2024
@PritishBudhiraja PritishBudhiraja self-assigned this Mar 13, 2024
let paymentLabel = showFields
? localeString.selectPaymentMethodLabel
: localeString.savedPaymentMethodsLabel
React.useEffect0(() => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a dependency here on paymentMethods?
cc: @prafulkoppalkar @vsrivatsa-juspay

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@akash-c-k akash-c-k merged commit 993767f into main Mar 13, 2024
3 checks passed
@akash-c-k akash-c-k deleted the button-text branch March 13, 2024 08:46
akash-c-k pushed a commit that referenced this pull request Mar 13, 2024
## [0.31.6](v0.31.5...v0.31.6) (2024-03-13)

### Bug Fixes

* pay now button text & theme based changes ([#223](#223)) ([993767f](993767f))
rising-dragon401 added a commit to rising-dragon401/hyperswitch-web that referenced this pull request Jul 2, 2024
## [0.31.6](juspay/hyperswitch-web@v0.31.5...v0.31.6) (2024-03-13)

### Bug Fixes

* pay now button text & theme based changes ([#223](juspay/hyperswitch-web#223)) ([993767f](juspay/hyperswitch-web@993767f))
ArushKapoorJuspay pushed a commit that referenced this pull request Sep 23, 2024
Merge in EXC/orca-elements from husky-hooks-semantic to main

* commit 'c938a076fd8abf719f5c4ade784f8f4273f420cd':
  feat: HS-126: added husky hooks and semantic-release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants