Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(redis_interface): implement functions for HGET, HSET, HSETNX commands #114

Merged
merged 1 commit into from
Dec 12, 2022
Merged

feat(redis_interface): implement functions for HGET, HSET, HSETNX commands #114

merged 1 commit into from
Dec 12, 2022

Conversation

SanchithHegde
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

This PR adds wrapper functions for HGET, HSET and HSETNX commands under the redis_interface crate and updates the router crate to use those functions.

Motivation and Context

This change removes the fred crate as a direct dependency of the router crate.

How did you test it?

Ran the application and created/retrieved payments via Postman.

Checklist

  • I formatted the code cargo +nightly fmt
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SanchithHegde SanchithHegde added A-framework Area: Framework C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Dec 12, 2022
@SanchithHegde SanchithHegde self-assigned this Dec 12, 2022
jarnura
jarnura approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@jarnura jarnura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jarnura jarnura merged commit 81593e0 into main Dec 12, 2022
@jarnura jarnura removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 12, 2022
@SanchithHegde SanchithHegde deleted the redis-hash-functions branch December 12, 2022 10:08
@SanchithHegde SanchithHegde mentioned this pull request Dec 13, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@vspecky vspecky Awaiting requested review from vspecky

@NishantJoshi00 NishantJoshi00 Awaiting requested review from NishantJoshi00

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@SanchithHegde SanchithHegde

Labels
A-framework Area: Framework C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SanchithHegde @jarnura