feat(connector): [ACI] implement Card Mandates for ACI #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakilmostak
added
A-connector-integration
ArjunKarthik
requested changes
May 17, 2023
There was a problem hiding this comment.
@Sakilmostak as discussed lets have the try_from for the payment methods
ArjunKarthik
added
S-waiting-on-author
Sakilmostak
added
R-waiting-on-L1
ArjunKarthik
requested changes
May 19, 2023
ArjunKarthik
added
the
S-waiting-on-author
Sakilmostak
removed
S-waiting-on-author
jagan-jaya
requested changes
Jun 13, 2023
| let payment_data = match wallet_data { | ||
| api_models::payments::WalletData::MbWay(data) => Self::Wallet(Box::new(WalletPMData { | ||
| payment_brand: PaymentBrand::Mbway, | ||
| account_id: Some(data.telephone_number.clone()), |
There was a problem hiding this comment.
why account_id is mapped with telephone_number?
There was a problem hiding this comment.
For MBway, the account Id is accepting in the telephone number format i.e telephone number is the account id for MBway in ACI
jagan-jaya
added
the
S-waiting-on-author
Sakilmostak
removed
the
S-waiting-on-author
SanchithHegde
added
the
S-waiting-on-review
jagan-jaya
approved these changes
Jun 29, 2023
ArjunKarthik
approved these changes
Jun 30, 2023
SanchithHegde
approved these changes
Jun 30, 2023
Comment on lines
+42
to
+47
| #[serde(flatten)] | ||
| pub txn_details: TransactionDetails, | ||
| #[serde(flatten)] | ||
| pub payment_method: PaymentDetails, | ||
| #[serde(flatten)] | ||
| pub instruction: Option<Instruction>, |
There was a problem hiding this comment.
Is there a reason why #[serde(flatten)] is being used here? Are these types being reused anywhere else?
Comment on lines
+302
to
+309
| #[derive(Debug, Clone, Serialize)] | ||
| #[serde(rename_all = "UPPERCASE")] | ||
| pub enum InstructionSource { | ||
| // Cardholder initiated transaction | ||
| Cit, | ||
| // Merchant initiated transaction | ||
| Mit, | ||
| } |
There was a problem hiding this comment.
Suggested change
| #[derive(Debug, Clone, Serialize)] | |
| #[serde(rename_all = "UPPERCASE")] | |
| pub enum InstructionSource { | |
| // Cardholder initiated transaction | |
| Cit, | |
| // Merchant initiated transaction | |
| Mit, | |
| } | |
| #[derive(Debug, Clone, Serialize)] | |
| pub enum InstructionSource { | |
| #[serde(rename = "CIT")] | |
| CardholderInitiatedTransaction, | |
| #[serde(rename = "MIT")] | |
| MerchantInitiatedTransaction, | |
| } |
This can be done instead, to keep it readable and achieve the desired result. You can take this up on a separate PR.
There was a problem hiding this comment.
Ok, resolving this in a seperate PR
SanchithHegde
removed
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Additional Changes
Motivation and Context
In ACI connector Card Mandates were not implemented, but it is important payment method which is needed in market so I implemented it.
How did you test it?
I tested it using Postman
Checklist
cargo +nightly fmt --allcargo clippy