feat(router): disable temp locker call for connector-payment_method flow based on env #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai-harsha-vardhan
added
A-core
sai-harsha-vardhan
changed the title
Narayanbhat166
approved these changes
Sep 11, 2023
| pm, | ||
| &payment_data.payment_intent, | ||
| &payment_data.payment_attempt, | ||
| if should_store_payment_method_data_in_vault( |
There was a problem hiding this comment.
Try if this check can be done only once
Sangamesh26
approved these changes
Sep 11, 2023
jarnura
approved these changes
Sep 12, 2023
jarnura
added
S-ready-for-merge
and removed
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
disable temp locker call for connector-payment_method flow based on env
Additional Changes
Motivation and Context
How did you test it?
UI Tests for Stripe
CIT mandate transaction for Stripe
MIT mandate transaction for Stripe
3DS payment for Trustpay
Bank redirect for Trustpay
Non3DS for Trustpay
Payment_token being null for all the above payments as temp locker is disabled
Checklist
cargo +nightly fmt --allcargo clippy