feat(payment_attempt): add kv for find last successful attempt #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracarys18
added
A-core
dracarys18
changed the title
dracarys18
requested review from
inventvenkat,
jarnura and
sai-harsha-vardhan
jarnura
requested changes
Sep 20, 2023
| @@ -50,7 +50,7 @@ impl<T: DatabaseStore> ReverseLookupInterface for RouterStore<T> { | |||
| er.change_context(new_err) | |||
| }) | |||
| }; | |||
| get_or_populate_redis(self, id, database_call).await | |||
| get_or_populate_redis(self, format!("reverse_lookup_{id}"), database_call).await | |||
There was a problem hiding this comment.
In all reverse lookup are we adding prefix as reverse_lookup_?
There was a problem hiding this comment.
Yeah because this doesn't have shard key so it needs a prefix to avoid key clashing.
jarnura
previously approved these changes
Sep 21, 2023
sai-harsha-vardhan
previously approved these changes
Sep 22, 2023
dracarys18
dismissed stale reviews from sai-harsha-vardhan and jarnura
via
3e32a42
sai-harsha-vardhan
approved these changes
Sep 25, 2023
jarnura
approved these changes
Sep 25, 2023
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add KV for last successful payment attempt
Motivation and Context
Add it in KV for better latency
How did you test it?
This function is being used in
refunds_create_core. So refund should succeed.Checklist
cargo +nightly fmt --allcargo clippy