Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): add mertics to apple pay flow #2235

Merged
merged 11 commits into from
Sep 22, 2023
Merged

feat(router): add mertics to apple pay flow #2235

merged 11 commits into from
Sep 22, 2023

Conversation

ShankarSinghC
Copy link
Contributor

@ShankarSinghC ShankarSinghC commented Sep 21, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Currently there are two flows for apple pay (manual and simplified). This pr adds metrics by which we can monitor payments create, succeeded and failed in the particular flow.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ShankarSinghC ShankarSinghC added A-core Area: Core flows C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Sep 21, 2023
@ShankarSinghC ShankarSinghC requested review from a team as code owners September 21, 2023 11:26
@ShankarSinghC ShankarSinghC self-assigned this Sep 21, 2023
vspecky
vspecky requested changes Sep 21, 2023
View reviewed changes
crates/router/src/core/payments.rs Outdated Show resolved Hide resolved
@ShankarSinghC ShankarSinghC requested a review from a team as a code owner September 22, 2023 06:44
vspecky
vspecky previously approved these changes Sep 22, 2023
View reviewed changes
sai-harsha-vardhan
sai-harsha-vardhan reviewed Sep 22, 2023
View reviewed changes
crates/router/src/core/payments.rs Show resolved Hide resolved
crates/router/src/core/payments.rs Outdated Show resolved Hide resolved
crates/router/src/core/payments.rs Outdated Show resolved Hide resolved
@vspecky vspecky added this pull request to the merge queue Sep 22, 2023
Merged via the queue into main with commit b9f25c4 Sep 22, 2023
10 checks passed
@vspecky vspecky deleted the add_metrix_to_apple_pay_flow branch September 22, 2023 10:43
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vspecky vspecky vspecky approved these changes

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@Sangamesh26 Sangamesh26 Sangamesh26 approved these changes

@srujanchikke srujanchikke srujanchikke approved these changes

Assignees

@ShankarSinghC ShankarSinghC

Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
September 2023 Milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ShankarSinghC @vspecky @sai-harsha-vardhan @Sangamesh26 @srujanchikke @SanchithHegde